Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong line count in interpreter #163

Closed
pdehaye opened this issue Nov 13, 2015 · 4 comments
Closed

Wrong line count in interpreter #163

pdehaye opened this issue Nov 13, 2015 · 4 comments

Comments

@pdehaye
Copy link

pdehaye commented Nov 13, 2015

"telling us that the LOAD_FAST instruction appears at position zero"
->
"telling us that the LOAD_FAST instruction appears at position six"

No?

@MichaelDiBernardo
Copy link
Collaborator

Thanks for catching this. I think @akaptur actually meant to use the very first instruction LOAD_CONST as the example in this paragraph, so we'll correct it to refer to that instruction instead.

MichaelDiBernardo added a commit that referenced this issue Nov 13, 2015
@pdehaye
Copy link
Author

pdehaye commented Nov 13, 2015

I think the sixth line would be more instructional, as there are several 0s on that dis.

@MichaelDiBernardo
Copy link
Collaborator

@pdehaye I think it's probably better to use the first instruction in the list, because it's easier to pick that one as one's eyes move from paragraph to source block. However, I think we should explicitly instruct the reader to look at the first instruction as an example.

Edit: This is now done in b9762c1

@akaptur
Copy link
Contributor

akaptur commented Nov 16, 2015

LGTM. Thanks @pdehaye for the catch and @MichaelDiBernardo for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants