-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong line count in interpreter #163
Comments
Thanks for catching this. I think @akaptur actually meant to use the very first instruction |
I think the sixth line would be more instructional, as there are several 0s on that dis. |
@pdehaye I think it's probably better to use the first instruction in the list, because it's easier to pick that one as one's eyes move from paragraph to source block. However, I think we should explicitly instruct the reader to look at the first instruction as an example. Edit: This is now done in b9762c1 |
LGTM. Thanks @pdehaye for the catch and @MichaelDiBernardo for the fix. |
"telling us that the LOAD_FAST instruction appears at position zero"
->
"telling us that the LOAD_FAST instruction appears at position six"
No?
The text was updated successfully, but these errors were encountered: