Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMQ-9161] Mark JDBC JournalPersistenceAdapter as deprecated for removal #989

Merged
merged 2 commits into from
Mar 14, 2023
Merged

[AMQ-9161] Mark JDBC JournalPersistenceAdapter as deprecated for removal #989

merged 2 commits into from
Mar 14, 2023

Conversation

mattrpav
Copy link
Contributor

@mattrpav mattrpav commented Mar 14, 2023

This replaces #931

Copy link
Contributor

@cshannon cshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as deprecated seems fine but it might be a good idea to add some comments as to why it's being removed, replacement in the future etc in case someone updates and their build flags it.

@mattrpav
Copy link
Contributor Author

Marking as deprecated seems fine but it might be a good idea to add some comments as to why it's being removed, replacement in the future etc in case someone updates and their build flags it.

@cshannon comments added.

@cshannon cshannon merged commit 04f589e into apache:main Mar 14, 2023
cshannon added a commit to cshannon/activemq that referenced this pull request Mar 15, 2023
The previous comment added in PR apache#989 added a second javadoc comment
which prevent Xbean from generating the correct schema
@cshannon
Copy link
Contributor

This commit broke the ActiveMQ schema parsing with the extra javadoc comment blocks, fixed in #990

cshannon added a commit that referenced this pull request Mar 15, 2023
The previous comment added in PR #989 added a second javadoc comment
which prevent Xbean from generating the correct schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants