Respect LogFormat when using ES logging with Json Format #13310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
reviewed
Dec 25, 2020
| try: | ||
| # pylint: disable=protected-access | ||
| return self.formatter._style.format(_ESJsonLogFmt(**log_line.to_dict())) | ||
| except Exception: # noqa pylint: disable=broad-except |
There was a problem hiding this comment.
What is the reason for exception?
There was a problem hiding this comment.
For now, I can only foresee KeyError here i.e. if log_format has a key that is not present in ES logs:
There was a problem hiding this comment.
But kept a broad-except to avoid any unforeseen exception but it is just a safeguard and keeps the same behavior as now i.e. return log_line.message
kaxil
force-pushed
the
show-log-meta-es
branch
from
56013df
to
fcda9ec
Compare
kaxil
added
the
full tests needed
This was a log standing bug / behaviour where Timestamps, log level, line number etc were not shown when using ElasticSearch Task Handler (Elasticsearch as remote logging) with json_format=True.
kaxil
force-pushed
the
show-log-meta-es
branch
from
fcda9ec
to
5ea5d44
Compare
XD-DENG
reviewed
Dec 25, 2020
XD-DENG
approved these changes
Dec 25, 2020
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 4, 2021
This was a log standing bug / behaviour where Timestamps, log level, line number etc were not shown when using ElasticSearch Task Handler (Elasticsearch as remote logging) with json_format=True. (cherry-picked from b6bf253) (cherry picked from commit d16baf79bcdfe0b0266d1ac08e07f12285971b82)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 4, 2021
This was a log standing bug / behaviour where Timestamps, log level, line number etc were not shown when using ElasticSearch Task Handler (Elasticsearch as remote logging) with json_format=True. (cherry-picked from b6bf253) (cherry picked from commit d16baf79bcdfe0b0266d1ac08e07f12285971b82) (cherry picked from commit 18644b5)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 5, 2021
This was a log standing bug / behaviour where Timestamps, log level, line number etc were not shown when using ElasticSearch Task Handler (Elasticsearch as remote logging) with json_format=True. (cherry-picked from b6bf253) (cherry picked from commit d16baf79bcdfe0b0266d1ac08e07f12285971b82)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 5, 2021
This was a log standing bug / behaviour where Timestamps, log level, line number etc were not shown when using ElasticSearch Task Handler (Elasticsearch as remote logging) with json_format=True. (cherry-picked from b6bf253)
Dr-Denzy
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 20, 2021
This was a log standing bug / behaviour where Timestamps, log level, line number etc were not shown when using ElasticSearch Task Handler (Elasticsearch as remote logging) with json_format=True. (cherry-picked from b6bf253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a log standing bug / behaviour where Timestamps, log level,
line number etc were not shown when using ElasticSearch Task Handler
(Elasticsearch as remote logging) with json_format=True.
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.