Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jobs check command for liveness probe check in airflow 2 #22143

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

ephraimbuddy
Copy link
Contributor

This PR proposes to remove the current use of python code for liveness probe check
commands in the Scheduler & Triggerer deployments

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer (when tests fixed)

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 10, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

chart/templates/_helpers.yaml Outdated Show resolved Hide resolved
chart/templates/_helpers.yaml Show resolved Hide resolved
chart/templates/scheduler/scheduler-deployment.yaml Outdated Show resolved Hide resolved
ephraimbuddy and others added 4 commits March 11, 2022 01:08
This PR proposes to remove the current use of python code for liveness probe check
commands in the Scheduler & Triggerer deployments
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@ephraimbuddy ephraimbuddy merged commit 33ecca1 into apache:main Mar 11, 2022
@ephraimbuddy ephraimbuddy deleted the liveness-probe-command branch March 11, 2022 07:03
@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.6.0 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants