Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the database configuration to a new section #22277

Closed
wants to merge 31 commits into from
Closed

Move the database configuration to a new section #22277

wants to merge 31 commits into from

Conversation

kelechi2020
Copy link
Contributor

closes: 15930

This PR moves the following configurations from [core] to the new [database] section.

  • sql_alchemy_conn
  • sql_engine_encoding
  • sql_engine_collation_for_ids
  • sql_alchemy_pool_enabled
  • sql_alchemy_pool_size
  • sql_alchemy_max_overflow
  • sql_alchemy_pool_recycle
  • sql_alchemy_pool_pre_ping
  • sql_alchemy_schema
  • sql_alchemy_connect_args
  • load_default_connections
  • max_db_retries

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backward-incompatible changes please leave a note in UPDATING.md.

Egbosi Kelechi and others added 30 commits February 21, 2022 11:12
@boring-cyborg boring-cyborg bot added area:CLI area:dev-tools area:helm-chart Airflow Helm Chart provider:cncf-kubernetes Kubernetes provider related issues area:production-image Production image improvements and fixes area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues kind:documentation labels Mar 15, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 15, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:dev-tools area:helm-chart Airflow Helm Chart area:production-image Production image improvements and fixes area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues kind:documentation provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the database configuration to a new section
3 participants