Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Docker example DAGs to new design #23167

Merged
merged 1 commit into from
Jun 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions airflow/providers/docker/example_dags/__init__.py

This file was deleted.

51 changes: 0 additions & 51 deletions airflow/providers/docker/example_dags/example_docker.py

This file was deleted.

101 changes: 0 additions & 101 deletions airflow/providers/docker/example_dags/example_docker_copy_data.py

This file was deleted.

14 changes: 13 additions & 1 deletion docs/apache-airflow-providers-docker/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Content
:maxdepth: 1
:caption: Resources

Example DAGs <https://github.com/apache/airflow/tree/main/airflow/providers/docker/example_dags>
Example DAGs <https://github.com/apache/airflow/tree/main/tests/system/providers/docker>
PyPI Repository <https://pypi.org/project/apache-airflow-providers-docker/>
Installing from sources <installing-providers-from-sources>

Expand Down Expand Up @@ -78,3 +78,15 @@ PIP package Version required
================== ==================

.. include:: ../../airflow/providers/docker/CHANGELOG.rst

DockerOperator
--------------
Use the
:class:`~airflow.providers.docker.operators.docker.DockerOperator`
to execute command in Docker container.

.. exampleinclude:: /../../tests/system/providers/docker/example_docker.py
:language: python
:dedent: 4
:start-after: [START howto_operator_docker]
:end-before: [END howto_operator_docker]
4 changes: 2 additions & 2 deletions docs/apache-airflow/tutorial_taskflow_api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ image must have a working Python installed and take in a bash command as the ``c

Below is an example of using the ``@task.docker`` decorator to run a Python task.

.. exampleinclude:: /../../airflow/providers/docker/example_dags/tutorial_taskflow_api_etl_docker_virtualenv.py
.. exampleinclude:: /../../tests/system/providers/docker/example_taskflow_api_etl_docker_virtualenv.py
:language: python
:dedent: 4
:start-after: [START transform_docker]
Expand All @@ -257,7 +257,7 @@ environment on the same machine, you can use the ``@task.virtualenv`` decorator
decorator will allow you to create a new virtualenv with custom libraries and even a different
Python version to run your function.

.. exampleinclude:: /../../airflow/providers/docker/example_dags/tutorial_taskflow_api_etl_docker_virtualenv.py
.. exampleinclude:: /../../tests/system/providers/docker/example_taskflow_api_etl_docker_virtualenv.py
:language: python
:dedent: 4
:start-after: [START extract_virtualenv]
Expand Down
63 changes: 63 additions & 0 deletions tests/system/providers/docker/example_docker.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import os
from datetime import datetime

from airflow import models
from airflow.operators.bash import BashOperator
from airflow.providers.docker.operators.docker import DockerOperator

ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
DAG_ID = 'docker_test'

with models.DAG(
DAG_ID,
schedule_interval="@once",
start_date=datetime(2021, 1, 1),
catchup=False,
tags=["example", "docker"],
) as dag:
t1 = BashOperator(task_id='print_date', bash_command='date', dag=dag)
t2 = BashOperator(task_id='sleep', bash_command='sleep 5', retries=3, dag=dag)
# [START howto_operator_docker]
t3 = DockerOperator(
docker_url='unix://var/run/docker.sock', # Set your docker URL
command='/bin/sleep 30',
image='centos:latest',
network_mode='bridge',
task_id='docker_op_tester',
dag=dag,
)
# [END howto_operator_docker]

t4 = BashOperator(task_id='print_hello', bash_command='echo "hello world!!!"', dag=dag)
# t1 >> t2
# t1 >> t3
# t3 >> t4

(
# TEST BODY
t1
>> [t2, t3]
>> t4
)

potiuk marked this conversation as resolved.
Show resolved Hide resolved
from tests.system.utils import get_test_run # noqa: E402

# Needed to run the example DAG with pytest (see: tests/system/README.md#run_via_pytest)
test_run = get_test_run(dag)
110 changes: 110 additions & 0 deletions tests/system/providers/docker/example_docker_copy_data.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

"""
This sample "listen to directory". move the new file and print it,
using docker-containers.
The following operators are being used: DockerOperator,
BashOperator & ShortCircuitOperator.
TODO: Review the workflow, change it accordingly to
your environment & enable the code.
"""
import os
from datetime import datetime

from docker.types import Mount

from airflow import models
from airflow.operators.bash import BashOperator
from airflow.operators.python import ShortCircuitOperator
from airflow.providers.docker.operators.docker import DockerOperator

ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
DAG_ID = 'docker_sample_copy_data'

with models.DAG(
DAG_ID,
schedule_interval="@once",
start_date=datetime(2021, 1, 1),
catchup=False,
tags=["example", "docker"],
) as dag:

locate_file_cmd = """
sleep 10
find {{params.source_location}} -type f -printf "%f\n" | head -1
"""

t_view = BashOperator(
task_id="view_file",
bash_command=locate_file_cmd,
do_xcom_push=True,
params={"source_location": "/your/input_dir/path"},
dag=dag,
)

t_is_data_available = ShortCircuitOperator(
task_id="check_if_data_available",
python_callable=lambda task_output: not task_output == "",
op_kwargs=dict(task_output=t_view.output),
dag=dag,
)

t_move = DockerOperator(
api_version="1.19",
docker_url="tcp://localhost:2375", # replace it with swarm/docker endpoint
image="centos:latest",
network_mode="bridge",
mounts=[
Mount(source="/your/host/input_dir/path", target="/your/input_dir/path", type="bind"),
Mount(source="/your/host/output_dir/path", target="/your/output_dir/path", type="bind"),
],
command=[
"/bin/bash",
"-c",
"/bin/sleep 30; "
"/bin/mv {{ params.source_location }}/" + str(t_view.output) + " {{ params.target_location }};"
"/bin/echo '{{ params.target_location }}/" + f"{t_view.output}';",
],
task_id="move_data",
do_xcom_push=True,
params={"source_location": "/your/input_dir/path", "target_location": "/your/output_dir/path"},
dag=dag,
)

t_print = DockerOperator(
api_version="1.19",
docker_url="tcp://localhost:2375",
image="centos:latest",
mounts=[Mount(source="/your/host/output_dir/path", target="/your/output_dir/path", type="bind")],
command=f"cat {t_move.output}",
task_id="print",
dag=dag,
)

(
# TEST BODY
t_is_data_available
>> t_move
>> t_print
)

from tests.system.utils import get_test_run # noqa: E402

# Needed to run the example DAG with pytest (see: tests/system/README.md#run_via_pytest)
test_run = get_test_run(dag)
Loading