Fix the error caused by passing unused context in JiraSensor.poke #23352
Conversation
| @@ -60,7 +60,7 @@ def poke(self, context: 'Context') -> Any: | |||
| jira_result = getattr(resource, self.method_name)(**self.method_params) | |||
| if self.result_processor is None: | |||
| return jira_result | |||
| return self.result_processor(context, jira_result) | |||
There was a problem hiding this comment.
Is there a reason we're not removing context from the poke method signature?
There was a problem hiding this comment.
poke on other sensors take context, so this probably should as well.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Could you add a test case to prevent future regressions? |
kianelbo
force-pushed
the
fix-jira-sensor-bug
branch
2 times, most recently
from
188f2a1
to
5c733a8
Compare
Good idea! However I couldn't find a neat way to add a new case to the test. Instead, I thought it would be worthwhile to use the original |
kianelbo
force-pushed
the
fix-jira-sensor-bug
branch
from
b53660b
to
25b8b3f
Compare
potiuk
force-pushed
the
fix-jira-sensor-bug
branch
from
25b8b3f
to
28eb50e
Compare
|
Rebased to rebuild. @kianelbo - please ping us if you see it's green or when you fix it, if it is red :). |
The sample ticket object used in the test is mocked more realistically and the original field_checker_func is used.
kianelbo
force-pushed
the
fix-jira-sensor-bug
branch
from
28eb50e
to
2f4589d
Compare
|
Thanks @kianelbo ! |
This tiny PR attempts to fix the error caused by #23046
(original issue: #22810 )