Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Windows development compatibility #24098

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Improve Windows development compatibility #24098

merged 5 commits into from
Jun 3, 2022

Commits on Jun 3, 2022

  1. Use platform.uname() for Windows support

    @uranusjr
    uranusjr committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b76c129 View commit details
    Browse the repository at this point in the history

  2. Fix multi-value env var formatting on Windows

    @uranusjr
    uranusjr committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    22d03d3 View commit details
    Browse the repository at this point in the history

  3. Set HOME environ if needed (for Windows)

    @uranusjr
    uranusjr committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b9b6ff4 View commit details
    Browse the repository at this point in the history

  4. Change bangs in pre-commit scripts to use 'python' 

    These are already run inside a virtual environment, so there's no need
to specify 'python3'. This greatly improves compatibility on Windows,
where the 'python3' command is not universally available.
    @uranusjr
    uranusjr committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    3e15b6c View commit details
    Browse the repository at this point in the history

  5. Make provider yml check compatible with Windows 

    This involves mostly converting things to pathlib and make use of
as_posix() to normalize paths.
    @uranusjr
    uranusjr committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    28acae9 View commit details
    Browse the repository at this point in the history