Move fallible ti.task.dag assignment back inside try/except block (#24533) #24592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
uranusjr
reviewed
Jun 22, 2022
It looks like ti.task.dag was originally protected inside try/except, but was moved out at commit 7be87d
ejk43
force-pushed
the
try-catch-dag-assignment
branch
from
85803b1
to
8d68822
Compare
uranusjr
reviewed
Jun 23, 2022
uranusjr
approved these changes
Jun 23, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
force-pushed
the
try-catch-dag-assignment
branch
from
81c6b3d
to
6eb5286
Compare
|
Another good catch. Thanks for the review and commit, I appreciate the detail. What's the process to get this into main branch from here? Is anything else needed? (first time PR for me) |
|
We generally need two committer reviews to merge a PR, so let’s wait for now. |
|
Awesome work, congrats on your first merged pull request! |
2 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 5, 2022
…4533) (#24592) * Move fallible ti.task.dag assignment back inside try/except block It looks like ti.task.dag was originally protected inside try/except, but was moved out at commit 7be87d * Remove unneeded variable annotation Co-authored-by: EJ Kreinar <ej@he360.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 97948ec)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 5, 2022
…4533) (#24592) * Move fallible ti.task.dag assignment back inside try/except block It looks like ti.task.dag was originally protected inside try/except, but was moved out at commit 7be87d * Remove unneeded variable annotation Co-authored-by: EJ Kreinar <ej@he360.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 97948ec)
74 tasks
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like ti.task.dag was originally protected inside try/except, but was moved out at commit 7be87d
This causes the "View Logs in Elasticsearch" option to crash in the Airflow UI
related: #24533