Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gcp_conn_id argument to GoogleDriveToLocalOperator #24622

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Add gcp_conn_id argument to GoogleDriveToLocalOperator #24622

merged 5 commits into from
Jun 24, 2022

Conversation

aspain
Copy link
Contributor

@aspain aspain commented Jun 23, 2022


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@aspain aspain requested a review from turbaszek as a code owner June 23, 2022 17:59
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 23, 2022
@aspain
Copy link
Contributor Author

aspain commented Jun 23, 2022

For #24494

@turbaszek turbaszek changed the title adding option to use non-default gcp_conn_id adding option to use non-default gcp_conn_id in GoogleDriveToLocalOperator Jun 23, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 23, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@mik-laj
Copy link
Member

mik-laj commented Jun 23, 2022

Black is still sad 😿

@uranusjr uranusjr changed the title adding option to use non-default gcp_conn_id in GoogleDriveToLocalOperator Add gcp_conn_id argument to GoogleDriveToLocalOperator Jun 24, 2022
@uranusjr uranusjr merged commit ded22eb into apache:main Jun 24, 2022
@aspain aspain deleted the patch-2 branch June 29, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants