Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few remaining references to flake8 #28915

Merged
merged 1 commit into from
Jan 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix a few remaining references to flake8
Some are just docs, others stopped some `breeze` commands from working
  • Loading branch information
ashb committed Jan 13, 2023
commit ed88811a01562f23a35010a4aa8d1461e68e26d5
1 change: 0 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@

!.coveragerc
!.rat-excludes
!.flake8
!.dockerignore
!pytest.ini
!RELEASE_NOTES.rst
Expand Down
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ CONTRIBUTORS_QUICK_START.rst export-ignore
.pre-commit-config.yaml export-ignore
.mailmap export-ignore
.editorconfig export-ignore
.flake8 export-ignore
.inputrc export-ignore
.codespellignorelines export-ignore
.gitmodules export-ignore
Expand Down
2 changes: 1 addition & 1 deletion .github/boring-cyborg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ firstPRWelcomeComment: >

Here are some useful points:

- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits](
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits](
https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
will help you with that.

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ as described in the static code checks documentation.
Coding style and best practices
===============================

Most of our coding style rules are enforced programmatically by flake8 and mypy (which are run automatically
Most of our coding style rules are enforced programmatically by ruff and mypy (which are run automatically
on every pull request), but there are some rules that are not yet automated and are more Airflow specific or
semantic than style

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTORS_QUICK_START.rst
Original file line number Diff line number Diff line change
Expand Up @@ -532,8 +532,8 @@ To avoid burden on CI infrastructure and to save time, Pre-commit hooks can be r

$ pre-commit run black --files airflow/decorators.py tests/utils/test_task_group.py
black...............................................................Passed
$ pre-commit run run-flake8 --files airflow/decorators.py tests/utils/test_task_group.py
Run flake8..........................................................Passed
$ pre-commit run ruff --files airflow/decorators.py tests/utils/test_task_group.py
Run ruff............................................................Passed



Expand Down
18 changes: 9 additions & 9 deletions STATIC_CODE_CHECKS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ require Breeze Docker image to be build locally.
In case you have a problem with running particular ``pre-commit`` check you can still continue using the
benefits of having ``pre-commit`` installed, with some of the checks disabled. In order to disable
checks you might need to set ``SKIP`` environment variable to coma-separated list of checks to skip. For example
when you want to skip some checks (flake/mypy for example), you should be able to do it by setting
``export SKIP=run-flake8,run-mypy``. You can also add this to your ``.bashrc`` or ``.zshrc`` if you
when you want to skip some checks (ruff/mypy for example), you should be able to do it by setting
``export SKIP=ruff,run-mypy``. You can also add this to your ``.bashrc`` or ``.zshrc`` if you
do not want to set it manually every time you enter the terminal.

In case you do not have breeze image configured locally, you can also disable all checks that require
Expand Down Expand Up @@ -382,7 +382,7 @@ code. But you can run pre-commit hooks manually as needed.

.. code-block:: bash

SKIP=run-mypy,run-flake8 pre-commit run --all-files
SKIP=run-mypy,ruff pre-commit run --all-files


You can always skip running the tests by providing ``--no-verify`` flag to the
Expand Down Expand Up @@ -412,17 +412,17 @@ Run the ``mypy`` check for all files:

breeze static-checks --type run-mypy --all-files

Run the ``flake8`` check for the ``tests.core.py`` file with verbose output:
Run the ``ruff`` check for the ``tests.core.py`` file with verbose output:

.. code-block:: bash

breeze static-checks --type run-flake8 --file tests/core.py --verbose
breeze static-checks --type ruff --file tests/core.py --verbose

Run the ``flake8`` check for the ``tests.core`` package with verbose output:
Run the ``ruff for the ``tests.core`` package with verbose output:

.. code-block:: bash

breeze static-checks --type run-flake8 --file tests/core/* --verbose
breeze static-checks --type ruff --file tests/core/* --verbose

Run all checks for the currently staged files:

Expand Down Expand Up @@ -457,10 +457,10 @@ Printing the commands while executing:

.. code-block:: bash

VERBOSE="true" pre-commit run --verbose run-flake8
VERBOSE="true" pre-commit run --verbose ruff

Just performing dry run:

.. code-block:: bash

DRY_RUN="true" pre-commit run --verbose run-flake8
DRY_RUN="true" pre-commit run --verbose ruff