Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1755] Allow mount below root #2952

Closed
wants to merge 1 commit into from

Conversation

bolkedebruin
Copy link
Contributor

@bolkedebruin bolkedebruin commented Jan 18, 2018

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This enables Airflow and Celery Flower to live
below root. Draws on the work of Geatan Semet
(@stibbons).

This closes #2723 and closes #2818

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

cc: @stibbons @artwr @ashb @jgao54 @Fokko

If we find the need to mount the API separately, we just have to put it in a separate "app" and mount it in the dispatcher.

@ashb
Copy link
Member

ashb commented Jan 18, 2018

No comments from me -- code looks simple, but I don't have time right now to test we've got all the URLs in the templates updated everywhere.

@gsemet
Copy link

gsemet commented Jan 18, 2018

+1

@bolkedebruin bolkedebruin force-pushed the AIRFLOW-1755 branch 2 times, most recently from 288ffd0 to 4847013 Compare January 18, 2018 15:24
This enables Airflow and Celery Flower to live
below root. Draws on the work of Geatan Semet
(@stibbons).

This closes apache#2723 and closes apache#2818
@codecov-io
Copy link

codecov-io commented Jan 18, 2018

Codecov Report

Merging #2952 into master will increase coverage by 0.1%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2952     +/-   ##
=========================================
+ Coverage   73.49%   73.59%   +0.1%     
=========================================
  Files         161      161             
  Lines       12237    12251     +14     
=========================================
+ Hits         8993     9016     +23     
+ Misses       3244     3235      -9
Impacted Files Coverage Δ
airflow/bin/cli.py 54.68% <0%> (-0.26%) ⬇️
airflow/www/views.py 71.68% <50%> (-0.04%) ⬇️
airflow/www/app.py 98.95% <91.66%> (+2.4%) ⬆️
airflow/jobs.py 79.92% <0%> (+0.44%) ⬆️
airflow/utils/helpers.py 54.02% <0%> (+2.87%) ⬆️
airflow/task/task_runner/bash_task_runner.py 100% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2bc8c...35e60ec. Read the comment docs.

@asfgit asfgit closed this in 1e36b37 Jan 19, 2018
Acehaidrey pushed a commit to Acehaidrey/incubator-airflow that referenced this pull request Jan 19, 2018
This enables Airflow and Celery Flower to live
below root. Draws on the work of Geatan Semet
(@stibbons).

This closes apache#2723 and closes apache#2818

Closes apache#2952 from bolkedebruin/AIRFLOW-1755
elan-jlepage added a commit to elancapital/incubator-airflow that referenced this pull request Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants