Better fix for add-back-references #33207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
kaxil,
pierrejeambrun,
ashb and
jedcunningham
as code owners
potiuk
requested review from
eladkal,
utkarsharma2,
hussein-awala and
amoghrajesh
potiuk
force-pushed
the
fix-back-reference-default-to-only-providers
branch
from
fbd8fcc
to
a2dc9b1
Compare
eladkal
reviewed
Aug 8, 2023
potiuk
force-pushed
the
fix-back-reference-default-to-only-providers
branch
2 times, most recently
from
b9cd062
to
24e752a
Compare
amoghrajesh
reviewed
Aug 8, 2023
dev/breeze/src/airflow_breeze/commands/release_management_commands.py
Outdated
Show resolved
Hide resolved
This is a better fix for add-back-references breeze command, as the previous fix had a bug and processed more than just providers when providers --gen-type was selected. See apache#33149. This version fixes it in a much more consistent way: * you have to specify what you want to work on as option * you can select few of the provider via auto-complete * you can also select apache-airflow and helm-chart * you can mix and match them if you need All the scripts and references where `--gen-type` was used previously have been updated and documentation was changed to reflect it
potiuk
force-pushed
the
fix-back-reference-default-to-only-providers
branch
from
24e752a
to
0ebfaa3
Compare
|
Applied round of comments from @amoghrajesh |
eladkal
approved these changes
Aug 9, 2023
amoghrajesh
approved these changes
Aug 9, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
This is a better fix for add-back-references breeze command, as the previous fix had a bug and processed more than just providers when providers --gen-type was selected. See #33149. This version fixes it in a much more consistent way: * you have to specify what you want to work on as option * you can select few of the provider via auto-complete * you can also select apache-airflow and helm-chart * you can mix and match them if you need All the scripts and references where `--gen-type` was used previously have been updated and documentation was changed to reflect it (cherry picked from commit 8c28454)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better fix for add-back-references breeze command, as
the previous fix had a bug and processed more than just providers
when providers --gen-type was selected. See #33149.
This version fixes it in a much more consistent way:
All the scripts and references where
--gen-typewas usedpreviously have been updated and documentation was changed to
reflect it
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.