-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding url sanitisation for extra links #41665
Conversation
Good catch! @amoghrajesh can you cherry pick this for |
Oh yeah. My Bad not asking for that. |
Marked it as 2.10.1 just in case we miss it accidentally. Also see #41457 (comment) - we should mark all such PRs as |
Ah thanks. Still getting used to this! |
(cherry picked from commit 6c463b3)
This reverts commit 6c463b3.
In the initial PR(apache#41665) we didn't handle the relative path in URL which led to issue(apache#41977). This PR aims at handling the relative path case when sanitizing URLs
Adding url sanitisation for the extra links that can be added and consumed as plugins.
The idea here is to disable the button if there's some violation and the url turns out to be un sanitised.
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.