Add ColumnChunkMetadataBuilder clear APIs
#6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/clear_stats
branch
from
7b7a912
to
02d8b98
Compare
alamb
commented
Oct 7, 2024
| @@ -1315,12 +1334,24 @@ impl ColumnChunkMetaDataBuilder { | |||
| self | |||
| } | |||
|
|
|||
| /// Clears the statistics for this column chunk. | |||
| pub fn clear_statistics(mut self) -> Self { | |||
There was a problem hiding this comment.
Unfortunately, set_statistics takes value: Statistics not value: Option<Statistics> and thus there is no way to make this change without breaking the API which we can't do until the next breaking release
| /// Sets page encoding stats for this column chunk. | ||
| pub fn set_page_encoding_stats(mut self, value: Vec<PageEncodingStats>) -> Self { | ||
| self.0.encoding_stats = Some(value); | ||
| self | ||
| } | ||
|
|
||
| /// Clears the page encoding stats for this column chunk. | ||
| pub fn clear_page_encoding_stats(mut self) -> Self { |
There was a problem hiding this comment.
The same reasoning applies to this API
etseidl
approved these changes
Oct 7, 2024
tustvold
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6504
Rationale for this change
I want to use the
ColumnChunkMetaDataBuilderto modify existing metadata in addition to creating new metadata, for the example in #6504.What changes are included in this PR?
ColumnChunkMetadataBuilder::clear_statisticsand other clear API to modifyOptionfieldsAre there any user-facing changes?
Some new APIs and docs