Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][GLib] Suppress "`unlink': Permission denied" warnings in tests on Windows #41770

Closed
kou opened this issue May 22, 2024 · 1 comment
Closed

[CI][GLib] Suppress "`unlink': Permission denied" warnings in tests on Windows #41770

kou opened this issue May 22, 2024 · 1 comment
Assignees
@kou
Labels
Component: Continuous Integration Component: GLib Type: enhancement
Milestone
17.0.0

Comments

@kou
Copy link
Member

kou commented May 22, 2024

Describe the enhancement requested

https://github.com/apache/arrow/actions/runs/9183539981/job/25254413025#step:12:83

test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1b01cf9f8 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-8gmqb9.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-8gmqb9.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1b01de598 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-jhtj66.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-jhtj66.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1b01f6d28 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-cm213m.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-cm213m.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1b022e818 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-9f22cw.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-9f22cw.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1b02b43c8 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-l8mur.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-l8mur.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1b038f6a8 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-h2rr21.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-h2rr21.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1b03ec7e0 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-8wxgv6.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-8wxgv6.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1b040ef48 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-n5khu0.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-n5khu0.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1ace305c0 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-whjqi1.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-whjqi1.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1aee7c360 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-nigllm.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-nigllm.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1afd42b38 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-5d2aoc.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-5d2aoc.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1afd74f98 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-moorbx.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-moorbx.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1afdc10a0 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-vq6f58.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-vq6f58.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1afdd83b8 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-giv9k1.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-giv9k1.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'
test/run-test.rb: warning: Exception in finalizer #<Tempfile::Remover:0x000001c1afdebf58 @pid=5072, @tmpfile=#<File:D:/a/_temp/data20240522-5072-967stm.parquet (closed)>>
C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `unlink': Permission denied @ apply2files - D:/a/_temp/data20240522-5072-967stm.parquet (Errno::EACCES)
	from C:/hostedtoolcache/windows/Ruby/3.1.5/x64/lib/ruby/3.1.0/tempfile.rb:265:in `call'

Component(s)

Continuous Integration, GLib
kou added a commit to kou/arrow that referenced this issue May 24, 2024
@kou
apacheGH-41770: [CI][GLib] Remove temporary files explicitly
2eb6613
@github-actions github-actions bot mentioned this issue May 24, 2024
Merged
kou added a commit that referenced this issue May 25, 2024
@kou
GH-41770: [CI][GLib] Remove temporary files explicitly (#41807)
7c8ce45 
### Rationale for this change

If we remove temporary files by GC, "`unlink': Permission denied" warnings are happen on Windows.

### What changes are included in this PR?

Use `Tempfile.create {...}` to remove temporary files explicitly.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41770

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 17.0.0 milestone May 25, 2024
@kou
Copy link
Member Author

kou commented May 25, 2024

Issue resolved by pull request 41807
#41807

@kou kou closed this as completed May 25, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@kou @vibhatha
apacheGH-41770: [CI][GLib] Remove temporary files explicitly (apache#…
5d0431b 
…41807)

### Rationale for this change

If we remove temporary files by GC, "`unlink': Permission denied" warnings are happen on Windows.

### What changes are included in this PR?

Use `Tempfile.create {...}` to remove temporary files explicitly.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41770

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Continuous Integration Component: GLib Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
1 participant
@kou