Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-14025: [R][C++] PreBuffer is not enabled when scanning parquet via exec nodes #11386

Closed
wants to merge 1 commit into from
Closed

ARROW-14025: [R][C++] PreBuffer is not enabled when scanning parquet via exec nodes #11386

wants to merge 1 commit into from

Conversation

nealrichardson
Copy link
Member

Also includes an unrelated CSV dataset test, just to confirm that FragmentScanOptions are passed through correctly.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-14025

westonpace
westonpace approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Let's run benchmarks real quick just to test.

@westonpace
Copy link
Member

@ursabot please benchmark lang=R

@ursabot
Copy link

ursabot commented Oct 12, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 157d48c and contender = c4ddad1. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Skipped ⚠️ Only ['C++', 'Java'] langs are supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@nealrichardson
Copy link
Member Author

Looks correct to me. Let's run benchmarks real quick just to test.

Great. Which benchmark do you expect to be affected by this, and how much?

@nealrichardson nealrichardson deleted the r-prebuffer branch October 12, 2021 20:13
@ursabot
Copy link

ursabot commented Oct 12, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 71612e3 and contender = 0fbd5e4. 0fbd5e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.04% ⬆️0.68%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@asfimport asfimport mentioned this pull request Oct 13, 2021
Closed
@jorisvandenbossche jorisvandenbossche mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nealrichardson @westonpace @ursabot @lidavidm