Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41784: [Packaging][RPM] Use SO version for -libs package name #41838

Merged
merged 1 commit into from
May 28, 2024

Conversation

kou
Copy link
Member

@kou kou commented May 27, 2024

Rationale for this change

We should use arrow${SO_VERSION}-libs not arrow${MAJOR_VERSION}-libs to co-exist newer versions and older versions.

What changes are included in this PR?

Use SO version not major version.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
Copy link
Member Author

kou commented May 27, 2024

@github-actions crossbow submit almalinux-9-amd64

Copy link

⚠️ GitHub issue #41784 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 27, 2024
@kou kou force-pushed the packaging-rpm-lib-version branch from 001315e to 02ad5f1 Compare May 27, 2024 02:42

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented May 27, 2024

@github-actions crossbow submit almalinux-9-amd64

This comment was marked as outdated.

@kou kou force-pushed the packaging-rpm-lib-version branch from 02ad5f1 to 51d6c73 Compare May 27, 2024 03:55
@kou
Copy link
Member Author

kou commented May 27, 2024

@github-actions crossbow submit almalinux-9-amd64

This comment was marked as outdated.

@kou kou force-pushed the packaging-rpm-lib-version branch from 51d6c73 to 110760c Compare May 27, 2024 04:59
@kou
Copy link
Member Author

kou commented May 27, 2024

@github-actions crossbow submit almalinux-9-amd64

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented May 28, 2024

@github-actions crossbow submit almalinux-* centos-* amazon-*

Copy link

Revision: 110760c

Submitted crossbow builds: ursacomputing/crossbow @ actions-b3ba2b154b

Task Status
almalinux-8-amd64 GitHub Actions
almalinux-8-arm64 GitHub Actions
almalinux-9-amd64 GitHub Actions
almalinux-9-arm64 GitHub Actions
amazon-linux-2023-amd64 GitHub Actions
amazon-linux-2023-arm64 GitHub Actions
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions

@kou
Copy link
Member Author

kou commented May 28, 2024

+1

@kou kou merged commit f904928 into apache:main May 28, 2024
6 checks passed
@kou kou deleted the packaging-rpm-lib-version branch May 28, 2024 04:17
@kou kou removed the awaiting committer review Awaiting committer review label May 28, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit f904928.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 18 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant