Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41679: [Release][Packaging][deb] Update package name in 01-preparesh too #41859

Merged
merged 1 commit into from
May 29, 2024

Conversation

kou
Copy link
Member

@kou kou commented May 28, 2024

Rationale for this change

It's needed when we publish minor release. For example:

$ dev/release/01-prepare.sh 16.0.0 17.0.0 # Release 16.0.0
...
$ dev/release/post-11-bump-versions.sh 16.0.0 17.0.0 # Released 16.0.0
...
$ dev/release/01-prepare.sh 16.1.0 17.0.0 # Release 16.1.0: This is effected
...
$ dev/release/post-11-bump-versions.sh 16.1.0 17.0.0 # Released 16.1.0

We can't detect minor release in post-11-bump-versions.sh.

What changes are included in this PR?

Share update codes via utils-prepare.sh and use the same logic in 01-prepare.sh too.

Linux packages related update code are also shared but it's not related to this change. Sorry.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

…repare.sh too

It's needed when we publish minor release. For example:

```console
$ dev/release/01-prepare.sh 16.0.0 17.0.0 # Release 16.0.0
...
$ dev/release/post-11-bump-versions.sh 16.0.0 17.0.0 # Released 16.0.0
...
$ dev/release/01-prepare.sh 16.1.0 17.0.0 # Release 16.1.0: This is effected
...
$ dev/release/post-11-bump-versions.sh 16.1.0 17.0.0 # Released 16.1.0
```
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 28, 2024
Copy link

⚠️ GitHub issue #41679 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the common code to the new functions!
In general looks good to me, I haven't found anything!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 28, 2024
@kou kou merged commit 9f58990 into apache:main May 29, 2024
6 of 7 checks passed
@kou kou deleted the packaging-release-deb-version branch May 29, 2024 05:14
@kou kou removed the awaiting merge Awaiting merge label May 29, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 9f58990.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants