Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Custom executor UI fix #43

Merged
merged 4 commits into from
Oct 15, 2018
Merged

Custom executor UI fix #43

merged 4 commits into from
Oct 15, 2018

Conversation

ridv
Copy link
Contributor

@ridv ridv commented Oct 10, 2018

With this patch two things are done:

  1. The executor name is exposed through the getTasksWithoutConfigs API. This is necessary for the UI to distinguish between Thermos based executors which expect a certain sandbox layout, and non-thermos based executors which do not have this concept.

This adds minimal overhead (in the case of thermos constant overhead) and doesn't reveal any more information than was previously known or obtainable through the getTaskStatus.

  1. Renders links to the thermos observer only if the executor used is thermos.
    Used a bold tag when non-thermos tasks are rendered for the Mesos agent address in order to maintain UI consistency.

screen shot 2018-10-10 at 3 17 09 pm

Copy link
Member

@StephanErb StephanErb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash your commits before merging :)

@ridv
Copy link
Contributor Author

ridv commented Oct 15, 2018

Thanks @StephanErb. The friendly neighborhood @jcohen made sure can only use the "Squash and merge" strategy so no more worries about wonky history 🙂

@ridv ridv merged commit 2be9315 into apache:master Oct 15, 2018
@ridv ridv added this to the 0.22.0 milestone Oct 22, 2019
@ridv ridv added the 0.22.0 Belongs to the 0.22.0 release label Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.22.0 Belongs to the 0.22.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants