This repository has been archived by the owner on May 12, 2021. It is now read-only.
Change devtoolset-7 (scl-rh) of CentOS6 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridv
approved these changes
Oct 14, 2018
| ) | ||
| build_centos6() { | ||
| local mesos_version=$1 output_basedir=$2 | ||
| local python_outdir=$output_basedir/centos/6/python | ||
| local image_name=centos:6 | ||
|
|
||
| pushd "$TMPDIR" | ||
| docker run -i -v $(pwd):/mesos-egg $image_name bash <<EOF | ||
| docker run -m=2g -i -v $(pwd):/mesos-egg $image_name bash <<EOF |
There was a problem hiding this comment.
Any particular reason CentOS6 requires the docker container to be limited to 2gb's of memory? Would be worth putting this as a comment if that's the case 🙂
| set -e -u | ||
|
|
||
| # We need Software Collections for Python 2.7 (we dropped support for 2.6). | ||
| # wget must get installed before everything else to fetch the additional repos. | ||
| yum -y install centos-release-SCL wget | ||
|
|
||
| # Mesos requires gcc 4.8, which is available in devtools-2 on centos 6. |
There was a problem hiding this comment.
Nit: We should leave a comment somewhere about why we're installing devtools-7 that way we know where to start looking if things break.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage http://mirror.centos.org/centos/6/sclo/x86_64/rh/devtoolset-7/