Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-13052] Implement ProtoPlusCoder and add it to the default options #15817

Merged
merged 6 commits into from
Nov 12, 2021
Merged

[BEAM-13052] Implement ProtoPlusCoder and add it to the default options #15817

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
936bfda
[BEAM-13052] Implement ProtoPlusCoder and add it to the default options
dpcollins-google Oct 27, 2021
d2e94ec
[BEAM-13052] Implement ProtoPlusCoder and add it to the default options
dpcollins-google Nov 1, 2021
5f1de7f
[BEAM-13052] Implement ProtoPlusCoder and add it to the default options
dpcollins-google Nov 1, 2021
cb4b96b
[BEAM-13052] Implement ProtoPlusCoder and add it to the default options
dpcollins-google Nov 2, 2021
b7bfcf3
[BEAM-13052] Implement ProtoPlusCoder and add it to the default options
dpcollins-google Nov 2, 2021
5e21f43
Roll back CoderRegistry __init__
dpcollins-google Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[BEAM-13052] Implement ProtoPlusCoder and add it to the default options 
Google cloud python client libraries use proto-plus for their protocol message wrappers, this coder enables them to be used in beam pipelines
  • Loading branch information
@dpcollins-google
dpcollins-google committed Nov 11, 2021
commit b7bfcf32d87b371e82e4dfcd4624aa4d92852b14
4 changes: 3 additions & 1 deletion sdks/python/apache_beam/coders/coders_test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,11 @@ def tearDownClass(cls):
coders.FastCoder,
coders.ListLikeCoder,
coders.ProtoCoder,
coders.ProtoPlusCoder,
coders.ToBytesCoder
])
cls.seen_nested -= set([coders.ProtoCoder, CustomCoder])
cls.seen_nested -= set(
[coders.ProtoCoder, coders.ProtoPlusCoder, CustomCoder])
assert not standard - cls.seen, str(standard - cls.seen)
assert not cls.seen_nested - standard, str(cls.seen_nested - standard)

Expand Down