Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-12164] Add javadocs to SpannerConfig #16879

Merged
merged 12 commits into from
Mar 3, 2022
Merged

[BEAM-12164] Add javadocs to SpannerConfig #16879

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5dbee76
Add tests and config for retry
zoercai Feb 9, 2022
4b99191
lint
zoercai Feb 9, 2022
835bb07
add tests
zoercai Feb 14, 2022
feb1bd3
lint
zoercai Feb 14, 2022
0c82dda
Delete tests not passing
zoercai Feb 14, 2022
8909673
Rebase on apache beam master
zoercai Feb 14, 2022
16ce8d8
review changes
zoercai Feb 15, 2022
361e6da
review changes
zoercai Feb 17, 2022
ceb94a1
add javadocs to SpannerConfig
zoercai Feb 17, 2022
78a5834
pull master
zoercai Mar 2, 2022
18da1f0
revert
zoercai Mar 2, 2022
12290eb
add full stops
zoercai Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete tests not passing
  • Loading branch information
@zoercai
zoercai committed Feb 14, 2022
commit 0c82dda978682ab69b94acddeeecad7f2550ed46
54 changes: 0 additions & 54 deletions ...t/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/SpannerChangeStreamErrorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,60 +127,6 @@ public void testResourceExhaustedDoesNotRetry() {
}
}

@Test
public void testDeadlineExceededDoesNotRetry() {
assertThat(
mockSpannerService.countRequestsOfType(ExecuteSqlRequest.class), Matchers.equalTo(0));
mockSpannerService.setExecuteStreamingSqlExecutionTime(
SimulatedExecutionTime.ofStickyException(Status.DEADLINE_EXCEEDED.asRuntimeException()));

final Timestamp now = Timestamp.now();
final Timestamp after3Seconds =
Timestamp.ofTimeSecondsAndNanos(now.getSeconds() + 3, now.getNanos());
try {
pipeline.apply(
SpannerIO.readChangeStream()
.withSpannerConfig(getSpannerConfig())
.withChangeStreamName(TEST_CHANGE_STREAM)
.withMetadataDatabase(TEST_DATABASE)
.withInclusiveStartAt(now)
.withInclusiveEndAt(after3Seconds));
pipeline.run().waitUntilFinish();
} finally {
assertThat(
mockSpannerService.countRequestsOfType(ExecuteSqlRequest.class), Matchers.equalTo(1));
thrown.expect(PipelineExecutionException.class);
thrown.expectMessage(ErrorCode.DEADLINE_EXCEEDED.name());
}
}

@Test
public void testInternalExceptionDoesNotRetry() {
mockSpannerService.setExecuteStreamingSqlExecutionTime(
SimulatedExecutionTime.ofStickyException(Status.INTERNAL.asRuntimeException()));
assertThat(
mockSpannerService.countRequestsOfType(ExecuteSqlRequest.class), Matchers.equalTo(0));

final Timestamp now = Timestamp.now();
final Timestamp after3Seconds =
Timestamp.ofTimeSecondsAndNanos(now.getSeconds() + 3, now.getNanos());
try {
pipeline.apply(
SpannerIO.readChangeStream()
.withSpannerConfig(getSpannerConfig())
.withChangeStreamName(TEST_CHANGE_STREAM)
.withMetadataDatabase(TEST_DATABASE)
.withInclusiveStartAt(now)
.withInclusiveEndAt(after3Seconds));
pipeline.run().waitUntilFinish();
} finally {
assertThat(
mockSpannerService.countRequestsOfType(ExecuteSqlRequest.class), Matchers.equalTo(1));
thrown.expect(PipelineExecutionException.class);
thrown.expectMessage(ErrorCode.INTERNAL.name());
}
}

@Test
public void testUnavailableExceptionRetries() {
mockSpannerService.setExecuteStreamingSqlExecutionTime(
Expand Down