Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-10976] Bundle finalization: Harness and some exec changes #16980

Merged
merged 10 commits into from
Mar 8, 2022
Merged

[BEAM-10976] Bundle finalization: Harness and some exec changes #16980

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
517dc6e
Bundle finalization harness side changes
damccorm Mar 1, 2022
1b9abf2
Add testing
damccorm Mar 1, 2022
ac4d3c2
Iterate over pardos directly
damccorm Mar 2, 2022
c780f59
Track bundlefinalizer in plan.go not pardo
damccorm Mar 2, 2022
64f40fc
Remove outdated test
damccorm Mar 2, 2022
dc5029d
Fix pointer issue
damccorm Mar 2, 2022
dbd0cb1
Update todos to reference jiras
damccorm Mar 3, 2022
e7dfa56
Cleanup from feedback
invalid-email-address Mar 7, 2022
3e4a89d
Doc nit
damccorm Mar 8, 2022
36e1450
GetExpirationTime comment
damccorm Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Doc nit 
Co-authored-by: Daniel Oliveira <younghoono@gmail.com>
  • Loading branch information
@damccorm @youngoli
damccorm and youngoli committed Mar 8, 2022
commit 3e4a89d78f8d13f6983a44d821148820288ea552
2 changes: 1 addition & 1 deletion sdks/go/pkg/beam/core/runtime/exec/plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func (p *Plan) Execute(ctx context.Context, id string, manager DataContext) erro
return nil
}

// Runs any callbacks registered by the bundleFinalizer. Should be run on bundle finalization.
// Finalize runs any callbacks registered by the bundleFinalizer. Should be run on bundle finalization.
func (p *Plan) Finalize() error {
if p.status != Up {
return errors.Errorf("invalid status for plan %v: %v", p.id, p.status)
Expand Down