Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-12164] Convert all static instances to be transient in the connector in order to enable concurrent testing #17036

Merged
merged 6 commits into from
Mar 9, 2022
Merged

[BEAM-12164] Convert all static instances to be transient in the connector in order to enable concurrent testing #17036

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3079f73
Convert all static instances to be transient in the connector in orde…
nancyxu123 Mar 8, 2022
d5001d8
Initialized fields to null
nancyxu123 Mar 8, 2022
5c9dfb1
nullness
nancyxu123 Mar 8, 2022
731d846
Suppress uninitialized warnings
nancyxu123 Mar 8, 2022
a086e86
Remove resetting dao factory fields in SpannerChangeStreamErrorTest.java
nancyxu123 Mar 8, 2022
2e86565
Add validation package
nancyxu123 Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Convert all static instances to be transient in the connector in orde… 
…r to enable concurrent testing
  • Loading branch information
@nancyxu123
nancyxu123 committed Mar 8, 2022
commit 3079f739fb7411f72cd08e5ae1ebd47804013bea
10 changes: 5 additions & 5 deletions .../src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/ActionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
public class ActionFactory implements Serializable {

private static final long serialVersionUID = -4060958761369602619L;
private static DataChangeRecordAction dataChangeRecordActionInstance;
private static HeartbeatRecordAction heartbeatRecordActionInstance;
private static ChildPartitionsRecordAction childPartitionsRecordActionInstance;
private static QueryChangeStreamAction queryChangeStreamActionInstance;
private static DetectNewPartitionsAction detectNewPartitionsActionInstance;
private transient DataChangeRecordAction dataChangeRecordActionInstance;
private transient HeartbeatRecordAction heartbeatRecordActionInstance;
private transient ChildPartitionsRecordAction childPartitionsRecordActionInstance;
private transient QueryChangeStreamAction queryChangeStreamActionInstance;
private transient DetectNewPartitionsAction detectNewPartitionsActionInstance;

/**
* Creates and returns a singleton instance of an action class capable of processing {@link
Expand Down
6 changes: 3 additions & 3 deletions ...atform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/DaoFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ public class DaoFactory implements Serializable {

private static final long serialVersionUID = 7929063669009832487L;

private static PartitionMetadataAdminDao partitionMetadataAdminDao;
private static PartitionMetadataDao partitionMetadataDaoInstance;
private static ChangeStreamDao changeStreamDaoInstance;
private transient PartitionMetadataAdminDao partitionMetadataAdminDao;
private transient PartitionMetadataDao partitionMetadataDaoInstance;
private transient ChangeStreamDao changeStreamDaoInstance;

private final SpannerConfig changeStreamSpannerConfig;
private final SpannerConfig metadataSpannerConfig;
Expand Down
4 changes: 2 additions & 2 deletions .../src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/mapper/MapperFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ public class MapperFactory implements Serializable {

private static final long serialVersionUID = -813434573067800902L;

private static ChangeStreamRecordMapper changeStreamRecordMapperInstance;
private static PartitionMetadataMapper partitionMetadataMapperInstance;
private transient ChangeStreamRecordMapper changeStreamRecordMapperInstance;
private transient PartitionMetadataMapper partitionMetadataMapperInstance;

/**
* Creates and returns a singleton instance of a mapper class capable of transforming a {@link
Expand Down