[BEAM-14129] Restructure SubscriptionPartitionLoader to use a manual SDF so its watermarks are reasonable given the polling semantics #17103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…termarks are reasonable given the polling semantics
|
R: @lukecwik |
|
Run Java PreCommit |
dpcollins-google
changed the title
lukecwik
reviewed
Mar 18, 2022
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Show resolved
Hide resolved
|
Run Java PreCommit |
lukecwik
requested changes
Mar 21, 2022
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Show resolved
Hide resolved
lukecwik
approved these changes
Mar 21, 2022
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Show resolved
Hide resolved
lukecwik
requested changes
Mar 22, 2022
...rc/main/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java
Show resolved
Hide resolved
…am/sdk/io/gcp/pubsublite/internal/SubscriptionPartitionLoader.java Fix race
|
Run Java PreCommit |
|
Manually kicked off Java PreCommit for this PR https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/21738 because the github comments aren't making it to Jenkins |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
Java PreCommit finally passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.