Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCollection data sampling for Java SDK harness #25064 #25354
PCollection data sampling for Java SDK harness #25064 #25354
Changes from 30 commits
cd630e4
e530d14
a09f5d6
1cb08f9
566c7b8
7395a2e
4c1253f
3d88254
5bbef91
6993b83
769902f
5c06d4e
99087e8
5609e4a
694c929
519aece
8efbb15
cd3732d
415e3f0
553fc5e
e260eb4
4f29308
8cbc6c8
f67234f
6815330
4848725
6c16576
822587d
fe9ab2a
07d37ea
5e9c4b0
f5f97fb
c3db7c0
fce6d69
69d8bb4
be2ebe4
93af06e
cbdbbc3
8cc8ee0
10aa7de
04c6c88
862439b
490be4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you want to sample the value with the windowing information attached?
The runner would be responsible for pulling out the attributes that are being sampled that can be introspected and/or saved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do, but I don't want to alter the encoding of the sampled bytes when sending back to the runner. It's not impossible, but I've found that there are a lot of mines when changing encodings.