Support for read from Cosmos DB Core SQL API #25672
Conversation
|
R: @kennknowles as you were part of the previous discussion in the linked PR |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #25672 +/- ##
==========================================
+ Coverage 71.05% 71.32% +0.26%
==========================================
Files 858 862 +4
Lines 104105 105206 +1101
==========================================
+ Hits 73976 75038 +1062
- Misses 28580 28619 +39
Partials 1549 1549
Flags with carried forward coverage won't be shown. Click here to find out more. see 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Miuler can you give it a try in a real setup ? I've only tested with testcontainers. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
RustedBones
force-pushed
the
azure-cosmos
branch
2 times, most recently
from
d2f1f81
to
24e9fe8
Compare
|
@kennknowles & @Abacn can you have a look as you commented on #23610 ? |
|
Thanks, taking a look |
sdks/java/io/azure-cosmos/src/main/java/org/apache/beam/sdk/io/azure/cosmos/CosmosIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/azure-cosmos/src/main/java/org/apache/beam/sdk/io/azure/cosmos/CosmosIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/azure-cosmos/src/main/java/org/apache/beam/sdk/io/azure/cosmos/CosmosIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/azure-cosmos/src/main/java/org/apache/beam/sdk/io/azure/cosmos/CosmosOptions.java
Outdated
Show resolved
Hide resolved
| @@ -612,6 +612,7 @@ class BeamModulePlugin implements Plugin<Project> { | |||
| aws_java_sdk2_regions : "software.amazon.awssdk:regions:$aws_java_sdk2_version", | |||
| aws_java_sdk2_utils : "software.amazon.awssdk:utils:$aws_java_sdk2_version", | |||
| aws_java_sdk2_profiles : "software.amazon.awssdk:profiles:$aws_java_sdk2_version", | |||
| azure_sdk_bom : "com.azure:azure-sdk-bom:1.2.14", | |||
There was a problem hiding this comment.
I updated to use the azure-sdk-bom to ensure azure module compatibility
…and move the feature in CHANGELOG.md to 2.45.0 version.
* feat(azure-cosmosdb): Add support for cosmosdb with Core (SQL) API Refs: apache#23604 * build(azure-cosmosdb): Add fleet in .gitignore * docs(azure-cosmosdb): Add scaladoc, license, experimental annotation and move the feature in CHANGELOG.md to 2.50.0 version. --------- Co-authored-by: Hector Miuler Malpica Gallegos <miuler@gmail.com>
* feat(azure-cosmosdb): Add support for cosmosdb with Core (SQL) API Refs: apache#23604 * build(azure-cosmosdb): Add fleet in .gitignore * docs(azure-cosmosdb): Add scaladoc, license, experimental annotation and move the feature in CHANGELOG.md to 2.50.0 version. --------- Co-authored-by: Hector Miuler Malpica Gallegos <miuler@gmail.com>
* feat(azure-cosmosdb): Add support for cosmosdb with Core (SQL) API Refs: apache#23604 * build(azure-cosmosdb): Add fleet in .gitignore * docs(azure-cosmosdb): Add scaladoc, license, experimental annotation and move the feature in CHANGELOG.md to 2.50.0 version. --------- Co-authored-by: Hector Miuler Malpica Gallegos <miuler@gmail.com>
Fix #23604
Follow-up from #23610
Implementation inspired from official azure-cosmos-spark