Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Checkstyle Results #28259

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

magicgoody
Copy link
Contributor

This PR was created to add an action that visualize the results of Checkstyle tests and adds them to the workflow summary page.

The action requires additional permissions:
checks: write (allow to add test result to workflow summary page)

Example runs:
no error: https://github.com/magicgoody/beam/actions/runs/5964470451
with error: https://github.com/magicgoody/beam/actions/runs/5949179444

Example screenshots:
Checkstyle result without violations
image

Checkstyle result with violations
image


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Aug 31, 2023
@magicgoody magicgoody marked this pull request as ready for review September 1, 2023 10:26
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/beam_PreCommit_Spotless.yml Outdated Show resolved Hide resolved
Co-authored-by: Danny McCormick <dannymccormick@google.com>
@damccorm damccorm merged commit e1523e4 into apache:master Sep 11, 2023
5 checks passed
andreydevyatkin pushed a commit to akvelon/beam that referenced this pull request Sep 14, 2023
* Publish checkstyle check

* Update .github/workflows/beam_PreCommit_Spotless.yml

Co-authored-by: Danny McCormick <dannymccormick@google.com>

---------

Co-authored-by: Danny McCormick <dannymccormick@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants