Fix Java PreCommit Action correct branch to run #28440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also upload human readable test reports on failure
damccorm
reviewed
Sep 13, 2023
| @@ -172,10 +173,11 @@ jobs: | |||
| -PdisableSpotlessCheck=true \ | |||
| -PdisableCheckStyle=true \ | |||
| - name: Upload test report | |||
| if: failure() | |||
There was a problem hiding this comment.
Should this be if: always()?
There was a problem hiding this comment.
There will be a third party workflow generating junit reports: #28075 to be added to all tests. This is available as a complement if one ones to see raw reports so failure() should suffice. I did not investigate how big the artifact could be so I would suggest roll out to failure() first
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
using a script checked that this the only one missed |
damccorm
approved these changes
Sep 14, 2023
| @@ -172,10 +173,11 @@ jobs: | |||
| -PdisableSpotlessCheck=true \ | |||
| -PdisableCheckStyle=true \ | |||
| - name: Upload test report | |||
| if: failure() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in #28434 (comment)
Also addressing #28075 (comment)
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.