-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Workflow Replacement for Jenkins Jobs, beam_LoadTests_Python_GBK_Dataflow_* #28827
Github Workflow Replacement for Jenkins Jobs, beam_LoadTests_Python_GBK_Dataflow_* #28827
Conversation
${{ github.workspace }}/.github/workflows/load-tests-job-configs/python_GBK_Dataflow_Batch_2GB_of_100kB_records.txt | ||
${{ github.workspace }}/.github/workflows/load-tests-job-configs/python_GBK_Dataflow_Batch_fanout_4_times_with_2GB_10-byte_records_total.txt | ||
${{ github.workspace }}/.github/workflows/load-tests-job-configs/python_GBK_Dataflow_Batch_fanout_8_times_with_2GB_10-byte_records_total.txt | ||
arguments: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better remove empty arguments
parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, thanks
# // TODO(https://github.com/apache/beam/issues/20403): Skipping some cases because they are too slow. | ||
# def TESTS_TO_SKIP = [ | ||
# 'load-tests-python-dataflow-streaming-gbk-1', | ||
# 'load-tests-python-dataflow-streaming-gbk-2', | ||
# 'load-tests-python-dataflow-streaming-gbk-4', | ||
# 'load-tests-python-dataflow-streaming-gbk-5', | ||
# ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# // TODO(https://github.com/apache/beam/issues/20403): Skipping some cases because they are too slow. | |
# def TESTS_TO_SKIP = [ | |
# 'load-tests-python-dataflow-streaming-gbk-1', | |
# 'load-tests-python-dataflow-streaming-gbk-2', | |
# 'load-tests-python-dataflow-streaming-gbk-4', | |
# 'load-tests-python-dataflow-streaming-gbk-5', | |
# ] | |
# // TODO(https://github.com/apache/beam/issues/20403). Skipping some cases because they are too slow: | |
# load-tests-python-dataflow-streaming-gbk-1 | |
# load-tests-python-dataflow-streaming-gbk-2 | |
# load-tests-python-dataflow-streaming-gbk-4 | |
# load-tests-python-dataflow-streaming-gbk-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
PR migrates Jenkins Jobs to Github Actions Workflow:
".github/workflows/beam_LoadTests_Python_GBK_Dataflow_Batch.yml"
".github/workflows/beam_LoadTests_Python_GBK_Dataflow_Streaming.yml"
Jenkins Jobs:
https://ci-beam.apache.org/view/LoadTests/job/beam_LoadTests_Python_GBK_Dataflow_Batch/
https://ci-beam.apache.org/view/LoadTests/job/beam_LoadTests_Python_GBK_Dataflow_Streaming/
The code has been tested on Self-hosted GKE runners ubuntu 20.04.
Example runs:
beam_LoadTests_Python_GBK_Dataflow_Batch.yml https://github.com/magicgoody/beam/actions/runs/6400975104
beam_LoadTests_Python_GBK_Dataflow_Streaming.yml https://github.com/magicgoody/beam/actions/runs/6401367865
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.