Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] add linkedIn case-study #28988

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

bullet03
Copy link
Contributor

  • add linkedIn case-study with related files

before:
before_linkedIn
after:
after_linkedIn

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@bullet03 bullet03 force-pushed the website-linkedin-case-study branch 5 times, most recently from 6414bd5 to ecb2540 Compare October 16, 2023 17:03
@bullet03 bullet03 marked this pull request as ready for review October 16, 2023 18:25
@bullet03 bullet03 marked this pull request as draft October 16, 2023 18:26
@dariabezkorovaina
Copy link
Contributor

@aaltay we've prepared this draft PR for the LinkedIn case study, but for the past 6 hours, the staging has been failing to build for some reason... Can you please help with this?

@aaltay
Copy link
Member

aaltay commented Oct 17, 2023

@liferoad - would it be possible for someone in the team to look at the failing beam_PreCommit_Whitespace . I looked at the logs, it seems to be failing because it is failing to setup the dependencies to run whitespace check and not because it is failing the whitespace check.

Reference to failed run: https://github.com/apache/beam/actions/runs/6536879246/job/17749540379?pr=28988

@aaltay aaltay marked this pull request as ready for review October 17, 2023 01:05
@aaltay
Copy link
Member

aaltay commented Oct 17, 2023

Run Whitespace PreCommit

@liferoad
Copy link
Collaborator

I doubt this is related to this PR. cc @damccorm

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm
Copy link
Contributor

I doubt this is related to this PR. cc @damccorm

Whitespace is back to green - https://github.com/apache/beam/actions/workflows/beam_PreCommit_Whitespace.yml?query=event%3Aschedule - there were several issues around checking for the new error of pip and downloading it that show up in the failures, guessing it was a transient pip remote issue.

Regardless, should be safe to ignore

@bullet03
Copy link
Contributor Author

R: @aaltay , could you, please help with the review of current PR?

@aaltay
Copy link
Member

aaltay commented Oct 17, 2023

Looks great, thank you!

@aaltay aaltay self-requested a review October 17, 2023 19:03
@aaltay aaltay merged commit 36574ce into apache:master Oct 17, 2023
7 checks passed
@aaltay
Copy link
Member

aaltay commented Oct 17, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants