-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Website] add linkedIn case-study #28988
Conversation
6414bd5
to
ecb2540
Compare
@aaltay we've prepared this draft PR for the LinkedIn case study, but for the past 6 hours, the staging has been failing to build for some reason... Can you please help with this? |
@liferoad - would it be possible for someone in the team to look at the failing beam_PreCommit_Whitespace . I looked at the logs, it seems to be failing because it is failing to setup the dependencies to run whitespace check and not because it is failing the whitespace check. Reference to failed run: https://github.com/apache/beam/actions/runs/6536879246/job/17749540379?pr=28988 |
Run Whitespace PreCommit |
I doubt this is related to this PR. cc @damccorm |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
ecb2540
to
f8ca45e
Compare
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Whitespace is back to green - https://github.com/apache/beam/actions/workflows/beam_PreCommit_Whitespace.yml?query=event%3Aschedule - there were several issues around checking for the new error of pip and downloading it that show up in the failures, guessing it was a transient pip remote issue. Regardless, should be safe to ignore |
R: @aaltay , could you, please help with the review of current PR? |
Looks great, thank you! |
before:
after:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.