Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image tag pattern for RCs in release docs #29406

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Update image tag pattern for RCs in release docs #29406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update image tag pattern for RCs in release docs
  • Loading branch information
@johannaojeling
johannaojeling committed Nov 11, 2023
commit 0b7569bf629df558fd9a5f7ec878eaca0d09c700
6 changes: 3 additions & 3 deletions contributor-docs/release-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,11 +578,11 @@ The following should be confirmed:
At
[https://hub.docker.com/u/apache](https://hub.docker.com/search?q=apache%2Fbeam&type=image),
visit each repository and navigate to "tags" tab. Verify images are pushed
with tags: `${RELEASE_VERSION}_rc{RC_NUM}`
with tags: `${RELEASE_VERSION}rc{RC_NUM}`

Verify that third party licenses are included in Docker. You can do this with a simple script:

RC_TAG=${RELEASE_VERSION}_rc{RC_NUM}
RC_TAG=${RELEASE_VERSION}rc{RC_NUM}
for pyver in 3.8 3.9 3.10 3.11; do
docker run --rm --entrypoint sh \
apache/beam_python${pyver}_sdk:${RC_TAG} \
Expand Down Expand Up @@ -775,7 +775,7 @@ as an example.
API reference manual](https://beam.apache.org/releases/pydoc/).
- [ ] Docker images are published to
[DockerHub](https://hub.docker.com/search?q=apache%2Fbeam&type=image) with
tags: `{RELEASE_VERSION}_rc{RC_NUM}`.
tags: `{RELEASE_VERSION}rc{RC_NUM}`.

You can (optionally) also do additional verification by:

Expand Down
6 changes: 3 additions & 3 deletions website/www/site/content/en/blog/validate-beam-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,15 @@ works well.
For Go SDK releases, you can fetch the Go SDK RC using [`go get`](https://golang.org/ref/mod#go-get),
by requesting the specific pre-release version.

For example, to request the first release candidate for 2.34.0:
For example, to request the first release candidate for 2.44.0:

```
go get -d github.com/apache/beam/sdks/v2@v2.34.0-RC1
go get -d github.com/apache/beam/sdks/v2@v2.44.0-RC1
```

With that, the Beam version in your `go.mod` will be the specified release candidate.
You can go ahead and run your tests to verify that everything works well.

You may need to also specify the RC's matching container when running a job.
Use the `--environment_config` flag to specify the release candidate container:
eg. `--environment_config=apache/beam_go_sdk:2.34.0_rc1`
eg. `--environment_config=apache/beam_go_sdk:2.44.0rc1`
Loading