Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcsio: support dict as the input of delete_batch #30188

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

shunping
Copy link
Contributor

@shunping shunping commented Feb 1, 2024

This smooths the code path of feeding output of list_prefix() to delete_batch().

fixes #30166


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@shunping shunping force-pushed the gcs-delete-batch branch 2 times, most recently from 6269695 to e5e4af8 Compare February 1, 2024 16:33
This smooths the code path of feeding output of list_prefix()
to delete_batch().
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit 1a5466b into apache:master Feb 1, 2024
71 checks passed
@shunping shunping changed the title gcsio: Support dict as the input of delete_batch gcsio: support dict as the input of delete_batch Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: GCSIO delete_batch breaks dataflow pipeline in 2.53
2 participants