Cleanup bigtable open resources on teardown #30453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed that a failure to process a bigquery
Mutation
(for instance due to a coder exception), results with the following error in the logs:The
bigtableWriter
andserviceEntry
resources are allocated in theStartBundle
and only closed in theFinishBundle
. If an exception is raised during theProcessElement
,FinishBunlde
is not called, resulting in a memory leak when retrying the step.This change makes sure to close those resources during the
TearDown
phase