Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add job name to GCS custom audit info #31316

Merged
merged 2 commits into from
May 17, 2024

Conversation

shunping
Copy link
Contributor

@shunping shunping commented May 16, 2024

This PR implements feature request #31299 for Java SDK.

We also try to make the Java user-agent consistent with the Python one (see #31300)
by inserting "apache-beam/VERSION".


Some more notes:

In Java SDK, GCSIO (from com.google.cloud.hadoop.gcsio) is used as an accessing layer to communicate with GCS. Internally, it depends on the storage client (from com.google.api.services.storage) to assemble and handle HTTP requests.

GCSIO can either create a new Google Cloud Storage client during initialization or utilize an existing one, which is the approach adopted by Beam. Ideally, it will be better if Beam can use the first code path so that we can leave all the GCS connection detail to GCSIO.

Follow-up tasks

@shunping
Copy link
Contributor Author

R: @damccorm @Abacn

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@shunping
Copy link
Contributor Author

Run Java PreCommit

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 28a7199 into apache:master May 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants