Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install TF on Python 3.12, since there is no compatible version atm. #31386

Merged
merged 2 commits into from
May 24, 2024
Merged

Don't install TF on Python 3.12, since there is no compatible version atm. #31386

merged 2 commits into from
May 24, 2024

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented May 24, 2024 •
edited
Loading

fixes: #31385

@tvalentyn tvalentyn requested a review from liferoad May 24, 2024 00:08
@liferoad
Copy link
Collaborator

Not sure the failed ML test is a concern.

@github-actions GitHub Actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor Author

Py3.12 suite passed: https://github.com/apache/beam/actions/runs/9216485596/job/25356862179?pr=31386, other suites are not affected by this PR.

@tvalentyn tvalentyn merged commit 1ed29e1 into apache:master May 24, 2024
82 of 85 checks passed
@tvalentyn tvalentyn deleted the py312_tf branch May 24, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liferoad liferoad liferoad approved these changes

Assignees
No one assigned
Labels
Next Action: Reviewers python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Python 3.12 ML Precommit suite is failing
2 participants
@tvalentyn @liferoad