Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ManagedIO] pass underlying transform URN as an annotation #31398

Merged
merged 9 commits into from
May 30, 2024
Merged

[ManagedIO] pass underlying transform URN as an annotation #31398

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d9c6532
pass underlying transform URN to annotation
ahmedabu98 May 24, 2024
6b0b4c8
move annotation keys to proto
ahmedabu98 May 24, 2024
dd20a70
spotless
ahmedabu98 May 24, 2024
bb85937
spotless
ahmedabu98 May 24, 2024
04a7d43
address comments: add descriptions for annotation enums; fail when mi…
ahmedabu98 May 28, 2024
974dcb7
spotless
ahmedabu98 May 28, 2024
569743e
move test to managed package
ahmedabu98 May 30, 2024
5d2c347
remove circular dependency
ahmedabu98 May 30, 2024
8de4529
revert
ahmedabu98 May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spotless
  • Loading branch information
@ahmedabu98
ahmedabu98 committed May 24, 2024
commit bb859372dceda4b5cd478e29710eaf658997b385
4 changes: 2 additions & 2 deletions .../java/core/src/main/java/org/apache/beam/sdk/util/construction/PTransformTranslation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import static org.apache.beam.sdk.util.construction.BeamUrns.getUrn;
import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkState;

import com.facebook.presto.hadoop.$internal.com.google.common.base.Objects;
import java.io.IOException;
import java.util.Collection;
import java.util.Collections;
Expand Down Expand Up @@ -60,6 +59,7 @@
import org.apache.beam.sdk.values.TupleTag;
import org.apache.beam.vendor.grpc.v1p60p1.com.google.protobuf.ByteString;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Joiner;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.MoreObjects;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableMap;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableSet;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableSortedSet;
Expand Down Expand Up @@ -533,7 +533,7 @@ public RunnerApi.PTransform translate(
Row configRow =
RowCoder.of(configSchema).decode(payload.getConfigurationRow().newInput());
String underlyingIdentifier =
Objects.firstNonNull(
MoreObjects.firstNonNull(
configRow.getString("transform_identifier"), "unknown_identifier");
ahmedabu98 marked this conversation as resolved.
Show resolved Hide resolved
transformBuilder.putAnnotations(
ahmedabu98 marked this conversation as resolved.
Show resolved Hide resolved
BeamUrns.getConstant(Annotations.Enum.MANAGED_UNDERLYING_TRANSFORM_URN_KEY),
Expand Down
Loading