Include Python 3.12 in release validation steps. #31415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @liferoad |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
(Also mentioned this in the wiki instructions). |
|
Do we know how long these tests could run now by adding this new Python version? |
|
probably no more than 25% longer, until we deprecate py3.8. |
liferoad
approved these changes
May 28, 2024
|
Thanks, I'll retry and if they still fail, I'll make sure the errors are tracked. Affected suites are unrelated to this change. |
|
Python precommits pass: https://github.com/apache/beam/actions/runs/9260981968/job/25475635769?pr=31415 but GHA somehow picks up a signal from the failing java suite (#31421 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include Python 3.12 for release validation purposes.
drive-by change: update a reference to docs tox task, it was recently changed, see:
beam/sdks/python/tox.ini
Line 148 in e764fc9
#29149