Solace Read connector: RetryCallable mechanism #31539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This was referenced Jun 7, 2024
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
16 tasks
bzablocki
force-pushed
the
solace-connector-2-retry-callable
branch
from
a34f0be
to
4e8817b
Compare
damondouglas
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
LGTM. I like your use of Interceptor. I'm learning from you by reviewing your PRs. Thank you, @bzablocki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 2nd PR for the Solace Read connector (addresses #31440).
It depends on the #31476 (root).
The files that are added/modified in this PR, comparing to the #31476:
This mechanism will be used for any network calls, such as creating and starting a message receiver (will be added in following PRs).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.