Fix PostCommit Java ValidatesRunner Samza job #31773
Conversation
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
| @@ -733,7 +733,7 @@ public void testWriteUnboundedWithCustomBatchParameters() throws Exception { | |||
| LINES2_ARRAY, | |||
| null, | |||
| null, | |||
| 3, | |||
| 0, | |||
| baseFilename, | |||
There was a problem hiding this comment.
this test is exercises by different runner's vallidaterunner test suite. Only SamzaRunner fails. Would this change break other runners test?
Probably we just need to exclude this specific test from validateRunner target in runners/samza/build.gradle
There was a problem hiding this comment.
It doesn't break other tests (tested with DirectRunner). If we pass 0, then it searches for file.txt*.
There was a problem hiding this comment.
I see, then it will no longer assert if the GroupintoBatches works as intended for those runners currently passing this test. Still think exclude from SamzaRunner test suite is preferred for now
Amar3tto
force-pushed
the
fix-postcommit-java-samza
branch
from
0b54b5b
to
6473ccb
Compare
Fixes #31725
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.