Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@JsonIgnore causes emulator endpoint to be missing in DoFn's #32450

Merged

Conversation

kberezin-nshl
Copy link
Contributor

@kberezin-nshl kberezin-nshl commented Sep 13, 2024

Unfortunately, BigQueryIO continues to refer to pipeline option post graph construction time, for example during @FinishBundle in UpdateSchemaDestination, and @JsonIgnore prevents endpoint URL to be serialized, and the whole thing doesn't work. This fixes that.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@kberezin-nshl
Copy link
Contributor Author

assign set of reviewers

@kberezin-nshl
Copy link
Contributor Author

Looks like the build failure is a flake.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Sep 16, 2024

thanks! rerun the failed test and will merge after it pass

@kberezin-nshl
Copy link
Contributor Author

retest this please

@kberezin-nshl kberezin-nshl force-pushed the nutshell_bq_endpoint_json_hidden_fix branch from 13e154c to 5d662a2 Compare September 17, 2024 08:14
@kberezin-nshl kberezin-nshl force-pushed the nutshell_bq_endpoint_json_hidden_fix branch from 5d662a2 to 097cf81 Compare September 17, 2024 09:58
@Abacn Abacn merged commit ff35dcb into apache:master Sep 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants