-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-7844] Custom MetadataHandler for RowRateWindow #9185
Conversation
R: @akedin |
Just changed the order of the arguments in RowRateWindow Constructor so that it becomes row rate window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, mostly stylistic questions:
...ensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/RowRateWindow.java
Outdated
Show resolved
Hide resolved
...ensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/RowRateWindow.java
Outdated
Show resolved
Hide resolved
...ensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/RowRateWindow.java
Outdated
Show resolved
Hide resolved
...sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/RowRateWindowMetadata.java
Outdated
Show resolved
Hide resolved
...sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/RowRateWindowMetadata.java
Outdated
Show resolved
Hide resolved
...va/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamSortRel.java
Outdated
Show resolved
Hide resolved
...ns/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/RelMdRowRateWindow.java
Outdated
Show resolved
Hide resolved
...ensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/RowRateWindow.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds a new MetadataHandler that is responsible for RowRateWindow estimation. This can be useful later when we implement beamComputeSelfCost().
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.