Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get the code #11

Merged
merged 6 commits into from
Feb 9, 2016
Merged

Fix get the code #11

merged 6 commits into from
Feb 9, 2016

Conversation

ahgittin
Copy link
Contributor

@ahgittin ahgittin commented Feb 8, 2016

Address @rdowner 's comments on #1

many more cross-links, and more detail in the menus
* make accordion so entire panel is link
* put `test-both` first in the build help
* remove obsolete submenu items in getting started

{% highlight bash %}
hub fork; git submodule foreach 'hub fork'
{% endhighlight %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I have just discovered worth noting! If you already have forks, this command still works - your fork is left alone but it still sets up the new remote.

@richardcloudsoft
Copy link
Contributor

Thanks @ahgittin, this improves usability(readability!) a lot. There's still some issues remaining, but IMO it's worth publishing these changes ASAP so I'm going to merge now and regenerate the main website.

@asfgit asfgit merged commit 6a4559b into apache:master Feb 9, 2016
asfgit pushed a commit that referenced this pull request Feb 9, 2016
@richardcloudsoft
Copy link
Contributor

Some things to add after my experiences with submodules...

I think that this command is necessary after the first git submodule update:

git submodule foreach "git checkout master"

Apache committers may benefit from these commands - it overrides the pushDefault (which is origin, or my personal fork) for the master branch to be the canonical Apache repo, so a simple git push on master will go to the canonical repo. (On the other hand, there's a good argument for not doing this, and requiring the apache-git remote name to be explicitly specified, to avoid accidentally pushing to the wrong place...)

git config branch.master.pushRemote apache-git
git submodule foreach "git config branch.master.pushRemote apache-git"

ahgittin added a commit to ahgittin/brooklyn-docs that referenced this pull request Feb 9, 2016
@ahgittin
Copy link
Contributor Author

ahgittin commented Feb 9, 2016

@richardcloudsoft I've applied and pushed the essential changes in fce745e .

Regarding apache-git as the default push target -- I really do not want that. I'm irritated as it is that the new version of git caches my password! I like the extra checks. Though now that force push is allowed it's not quite so grave.

As for the other comments I could go either way. Probably slightly prefer it as it is, longwinded but thorough, but happy if someone cleans it up further. (OTOH removing the script to make it like this is was a great suggestion! Thanks.)

@richardcloudsoft
Copy link
Contributor

Ok that's great, I think we're done for now. Thanks for taking the time to make the changes - I think it's made the first (developer) contact much more straightforward!

tommclaughlan pushed a commit to diffusiondata/brooklyn-docs that referenced this pull request Jan 18, 2018
asfgit pushed a commit that referenced this pull request Oct 4, 2021
Add LDAP_DOMAIN and fix brooklyn-* replacements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants