Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use local version of zeroclipboard movie #16

Merged
merged 1 commit into from
Feb 21, 2016

Conversation

ahgittin
Copy link
Contributor

fixes issues in some recent browser (eg latest chrome on latest os x)
where the flash "movie" won't load unless it is local.
the error it gives is a generic "uncaught exception" in
ZeroClipboard activate -> flashState.bridge.setSize.
curiously it still works fine in some browsers (firefox) and
older chrome was also fine but I'm guessing
security modes are being tightened in browsers.

none of the other recommended settings for fixing this seem to work:
* trustedDomains
* trustedOrigin
* allowScriptAccess
* and even the flash config in the browser

it's just a small movie however so should be low impact (smaller than most of our images).
put in img path to simplify access.

also, zeroclipboard is updated from 1.3.1 to 1.3.5 (latest stable 1.x branch).
(2.x branch looks like it might be a bigger api change although some fixes in this area are reported.)

note the SWF binary is downloaded on first run of _build/build.sh,
similar to as we do for the brooklyn-ui project, and also with a README in that dir

    fixes issues in some recent browser (eg latest chrome on latest os x)
    where the flash "movie" won't load unless it is local.
    the error it gives is a generic "uncaught exception" in
    ZeroClipboard activate -> flashState.bridge.setSize.
    curiously it still works fine in some browsers (firefox) and
    older chrome was also fine but I'm guessing
    security modes are being tightened in browsers.

    none of the other recommended settings for fixing this seem to work:
    * trustedDomains
    * trustedOrigin
    * allowScriptAccess
    * and even the flash config in the browser

    it's just a small movie however so should be low impact (smaller than most of our images).
    put in img path to simplify access.

    also, zeroclipboard is updated from 1.3.1 to 1.3.5 (latest stable 1.x branch).
    (2.x branch looks like it might be a bigger api change although some fixes in this area are reported.)

    note the SWF binary is downloaded on first run of _build/build.sh,
    similar to as we do for the brooklyn-ui project, and also with a README in that dir
@ahgittin
Copy link
Contributor Author

update of #12 addressing @rdowner 's points (which may not be necessary here as this is not in the source build, but seems good practise).

nearly identical to apache/brooklyn-ui#8 , just for the docs, and relies on curl in the _build/build.sh script.

@ahgittin
Copy link
Contributor Author

merging as this is a fix of a previous PR

@asfgit asfgit merged commit 602ca54 into apache:master Feb 21, 2016
asfgit pushed a commit that referenced this pull request Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants