Fix copy-state usage for brooklyn-karaf #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakomis
reviewed
Jun 21, 2018
|
|
||
| tar --exclude '*/backups/*' -czvf $BACKUP_FILENAME $TEMP_DATA_DIR | ||
| # For s3cmd installation see http://s3tools.org/repositories |
There was a problem hiding this comment.
I know it's not directly related to this PR, but we should switch to recommending the official AWS CLI now that it's mature and stable:
# For AWS CLI installation see https://aws.amazon.com/cli
aws s3 cp $BACKUP_FILENAME s3://mybackupbucket
rm $BACKUP_FILENAME
|
One minor comment, other than that LGTM |
This was referenced Jun 21, 2018
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2018
Fix copy-state usage for brooklyn-karaf In brooklyn classic, one could run `brooklyn copy-state ...`. This is not supported in brooklyn karaf. Instead, the REST api can be used. This PR updates the docs to show how to use it. Please first review/merge apache/brooklyn-server#972, to fix this REST api for usage in karaf!
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2018
Use the official AWS CLI instead of s3cmd Based on this comment: #258 (comment) Note: I checked the docs and this is the only place where we suggested to use `s3cmd`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In brooklyn classic, one could run
brooklyn copy-state .... This is not supported in brooklyn karaf.Instead, the REST api can be used. This PR updates the docs to show how to use it.
Please first review/merge apache/brooklyn-server#972, to fix this REST api for usage in karaf!