Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation snippet to show how entities can be tagged and added to Quick Launch #298

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Added documentation snippet to show how entities can be tagged and added to Quick Launch #298

merged 2 commits into from
Jan 7, 2020

Conversation

iuliana
Copy link
Contributor

@iuliana iuliana commented Jan 6, 2020

Added documentation snipped to show how entities can be tagged and added to the quick launch.
The documentation snippet can be found in the Catalog Items YAML Syntax

@iuliana iuliana changed the title Added documentation snipped to show how entities can be tagged and ad… Added documentation snipped to show how entities can be tagged and added to Quick Launch Jan 6, 2020
@iuliana iuliana changed the title Added documentation snipped to show how entities can be tagged and added to Quick Launch Added documentation snippet to show how entities can be tagged and added to Quick Launch Jan 7, 2020
tbouron
tbouron reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@tbouron tbouron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @iuliana !

I would maybe add a header like Add item to quick launch to avoid this section to be "lost", but feel free to ignore if you disagree.

@iuliana
Copy link
Contributor Author

iuliana commented Jan 7, 2020

Very nice idea @tbouron. Done. :)

tbouron
tbouron approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@tbouron tbouron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM @iuliana. Merging...

@tbouron tbouron merged commit 3ba088a into apache:master Jan 7, 2020
@ahgittin ahgittin mentioned this pull request Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouron tbouron tbouron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuliana @tbouron