Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document recent addition to allow arbitrary beans to be added to catalog and used in config, initializers, and elsewhere #309

Merged

Conversation

ahgittin
Copy link
Contributor

No description provided.

Copy link
Contributor

@geomacy geomacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one semi-typo.

One optional thought, perhaps it would be good to add an example spec using a bean.

When specifying the type of an initializer, registered types (added to the catalog) are preferred,
but Java types are permitted.

Advanced note: When implementing is preferred to use standard Jackson serialization methods to read/set fields,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit confusing, do you mean "when implementing, it is preferred to..."

@asfgit asfgit closed this in f34d2b5 Dec 7, 2020
@asfgit asfgit merged commit f34d2b5 into apache:master Dec 7, 2020
@ahgittin
Copy link
Contributor Author

ahgittin commented Dec 7, 2020

Thanks! Fixed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants