Switch from NodeJS/Gitbook back to Ruby/Jekyll, using latest Ruby #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert irrelevant commit
merged with conflicts, will be reverted
revert to mention rvm not nvm etc
…0-reverted-222 fix various places where this conflicted with reversion of 222 or caused errors
will fix ruby running shortly
and add it and its sibling to the parent
site_structure needs to supply a path for the cache; include_relative should be used instead of include, without quotes
as done for site
because assign now does a deep recursive size/score count which fails on looped structures; using it causes a stack too deep error
compared with old SUMMARY.md (gitbook way) to make sure things which previously would have had to be added there are added here under at least one parent
duncangrant
approved these changes
May 21, 2021
There was a problem hiding this comment.
LGTM. I've tested locally and I can set up jekyll and build following the instructions. Pages seem to be generated correctly and internal links seem to work.
It's a shame that gitbook has moved away from OSS but Jekyll is being actively developed and is currently well supported so this is a sensible move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the swtich to Gitbook, as nice as it was, it long ago stopped being nicely supported OSS so simplest thing to do is to go back to Ruby/Jekyll. Unfortunately it has moved on and a lot of things here got broken -- but we think this fixes them all.