Workflow - update-children and more #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 19, 2023 15:05
jcabrerizo
approved these changes
May 22, 2023
There was a problem hiding this comment.
Thanks @ahgittin , this sounds really powerful. Looking forward to see it running
ahgittin
changed the title
iuliana
reviewed
May 24, 2023
iuliana
requested changes
May 24, 2023
There was a problem hiding this comment.
One non-critical suggestion.
One critical: either the stack example is wrong, or we are not processing the aws cloudformation describe-stacks json right, because I am getting InvalidReferenceException: The following has evaluated to null or missing: ==> describe_stacks_output_json.Stacks [in template "workflow" at line 1, column 3] when the last step is executed
iuliana
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.